kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Latest update breaks it completely on Waterfox #101

Open tomose opened 4 years ago

tomose commented 4 years ago

I've reverted to 3.4 and disabled updates and things are working fine now.

Clicking the containerise icon brings up a blank list of containers and a little loading bar that never stops.

If you choose to test this you will need to change these settings in about:config to get containers enabled on WF: https://www.reddit.com/r/waterfox/comments/aj5cin/multiaccount_container_addon_incompatible_with/eri5tg5/

I'll understand though if you choose not to support WF as it's still on the old FF stuff and not the new api trash for addons that FF moved to. Just figured I'd let you know that 3.5 doesn't play well on WF. :)

LoveIsGrief commented 4 years ago

Hi,

Could you:

tomose commented 4 years ago

TypeError: browser.contextualIdentities.onRemoved is undefined index.js:1:4665

LoveIsGrief commented 4 years ago

Hmm... without that, temporary containers would need a fallback to periodically testing if any tabs are still open in a container :slightly_frowning_face: (right now the test is done when a tab closes).

I'll label this as "help wanted" since I don't use waterfox myself.

c33s commented 4 years ago

not sure if the Cannot send function call result call is also from this addon, its not triggered all the time so i assume its not directly connected to this addon.

TypeError: browser.contextualIdentities.onRemoved is undefined and Error: WebExtension context not found! are always triggered on my machine by clicking on the addons icon.

Cannot send function call result: other side closed connection (call data: ({path:"storage.sync.get", args:["settings"]}))
Cannot send function call result: other side closed connection (call data: ({path:"storage.sync.get", args:["settings"]}))
TypeError: browser.contextualIdentities.onRemoved is undefined[Learn More]  index.js:1:4776
    addOnRemoveListener moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:4776
    t.default< moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:3930
    <anonymous> moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:3851
    s moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:105
    <anonymous> moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:10732
    s moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:105
    <anonymous> moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:10667
    s moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:105
    <anonymous> moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:910
    <anonymous> moz-extension://e390f3c8-881f-4649-a5b6-686ffab9d5b7/ui/index.js:1:2
TypeError: Argument 1 of StructuredCloneHolder.deserialize is not an object.[Learn More]  ExtensionChild.jsm:786:24
Error: WebExtension context not found!  ExtensionParent.jsm:778:13
Cannot send function call result: other side closed connection (call data: ({path:"storage.sync.get", args:["settings"]}))

2020-03-07 12_37_20- #  about_config - Waterfox Classic  #

@LoveIsGrief maybe you can install waterfox in parallel for fixing this? https://www.waterfox.net/download/ (its maybe easier for you to install waterfox, that to find one with firefox addon coding skills and waterfox :smile:)