search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Browsing sites bound to No Container open up in new tabs #102

Closed Nepherte closed 4 years ago

Nepherte commented 4 years ago

As of version 3.5.0, when browsing sites that are bound to "No Container", will open up a new tab every time instead of staying within that tab.

E.g. github.com as the only rule stored under No Domain. Going from one github page to the other, triggers the creation of a new tab every time (and closes the old tab if configured it as such under settings). Browsing sites for which no rule exist (not even for "No Container"), still works as expected.

LoveIsGrief commented 4 years ago

I can't reproduce your issue.

Could you post the relevant rules and a screenshot of your settings? Have you activated default containers?

Nepherte commented 4 years ago

Settings:

Screenshot 2019-10-09 at 22 48 52

Rules: github.com , No Container

Steps to reproduce:

  1. Open github.com in Firefox (69.0.2)
  2. Click on 'Enterprise' link in the toolbar => Actual: the current tab gets closed, a new tab opens with the new url => Expected: new url opens in the active tab
LoveIsGrief commented 4 years ago

Thanks for the steps! I was able to reproduce it.

OdinGitDat commented 4 years ago

Can this fix be pushed to release asap? I've been waiting to update since #89

kintesh commented 4 years ago

@OdinGitDat just released!