search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Open unmatched URL in default container doesn't work with local html files #103

Closed Nepherte closed 4 years ago

Nepherte commented 4 years ago

When enabling the setting "open unmatched URL in a default container", I am no longer able to open html files locally available on my machine (ie. file:///path/to/my/file.html).

It initially opens up in Firefox in No Container, subsequently closes the tab (expected), but doesn't open the file in a new tab within the configured default container.

LoveIsGrief commented 4 years ago

Thanks for the bug report. Was able to reproduce this with default containers as well as older versions that matched file:// URLs.

tabs.create simply doesn't support those type of URLs.

They'll simply have to be ignored.

Nepherte commented 4 years ago

In my case, I dont want to bind them to a specific container so I don't mind them being in "No Container"

LoveIsGrief commented 4 years ago

We can't reassign / reopen tabs with file:// URLs at all due to the webextension API refusing to do that. The pull request / "fix" will have to exclude such URLs completely from treatment. Unfortunately, the user will have to do the work of reopening the tab in the wished container themselves

Nepherte commented 4 years ago

That's an acceptable solution. No worries.