kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Add ability to ignore tabs (to prevent infinite loops) #113

Open KnightTim opened 4 years ago

KnightTim commented 4 years ago

If you use a container add-on like Mozilla's Facebook Container or one of the many forks, this add-on will fight with it. The tab will open and close infinitely.

To reproduce this:

You can fix this by adding all the same rules to containerise, but it is harder to add certain rules. For example the google container has the option to not load google search pages in the google container. More complicated rules like that seem difficult to emulate in containerise.

I suggest that a good way to fix this is allow the user to have another option, like the "No container" option. Create an "Ignored tabs", allow the user to put domains and regex which containerise will use to not act on any matching tabs.

Hout commented 4 years ago

:+1:

LoveIsGrief commented 4 years ago

I suggest that a good way to fix this is allow the user to have another option, like the "No container" option. Create an "Ignored tabs", allow the user to put domains and regex which containerise will use to not act on any matching tabs.

I feel like I'm missing something here. Isn't that just the equivalent of not adding those rules to containerise?

KnightTim commented 4 years ago

If you enable "Default Container" every tab you open is acted on. Even tabs that have no rules.

LoveIsGrief commented 4 years ago

Ah, that's what I missed.

freewill404 commented 4 years ago

Any updates on this? :)

LoveIsGrief commented 4 years ago

I'm working on other projects, but PRs are welcome