search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Correct Syntax for Default Containers to Not Override Existing Entries in the CSV File? #123

Open CrafterLaughter opened 4 years ago

CrafterLaughter commented 4 years ago

Brilliant work with https://github.com/kintesh/containerise/pull/91

In testing out the default container function using the variable {domain} for container name without any rule additions. Prior to that I already had the following rule in my CSV file. !*.github.com , GitHub

With the default container function enabled as described, a new container launched for github as a result of the default container function, so I had to log in again.

I think the default container function is brilliant and I'd set the lifetime to "until the last tab is closed" otherwise I'd wind up overrun with thousands of permanently created containers in my containers list. Yet, by using the ""until the last tab is closed" function it would force me to re-login to sites over and over again if I close the tab.

Is there possible variables/syntax/ruleset that can be used sot that default container creation doesn't interfere with existing entries in the CSV file? Thanks again for all you guys do!

LoveIsGrief commented 4 years ago

Hello again :slightly_smiling_face:

This looks more like a bug. It should be resolving to the existing Github container and only fallback to a default container when the former is unsuccessful.

Thanks for reporting

CrafterLaughter commented 4 years ago

I'm pretty sure I made a foolish error and mistakenly had "match domain only" activated along with "default container."

I just tested three domains again with "match domain only" deselected and it appears to work great. Sorry for the distraction. I gather it was coded perfectly. Kind Regards.

orthand commented 3 years ago

I've recently switched from MAC and TC to Containerise to use the "default container" option and am having some trouble setting up all my containers. The only issue I could find mentioning similar problems was this one, so I hope this gives additional insight as it seems rather close.

What happens: I add a new entry to the list, open it up in a new tab to log on, close the tab and the entry gets deleted from the list. This seems to be depending on the "until the last tab is closed" setting from default containers. Though it should not interfere with the manually added containers. Is there any way to prevent this from happening aside from always having to go into the addon-settings and manually checking the set lifetime?

I presume that there still is a temporary default container when adding it to the "forever"-list (I've made it a habit to close all tabs from a website before adding it but that doesn't always seem to work) and the lifetime setting doesn't change upon adding it. Could the lifetime be checked+changed when adding an entry to the permanent list to avoid this?

I'm on Firefox 85.0, 64bit, Win10, MAC+TC disabled. Default container is set to {domain} and "until last tab is closed".