kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

Multi-Account Container & Containerise not blending. #129

Open Solid-Ice8 opened 4 years ago

Solid-Ice8 commented 4 years ago

Containerise Version: 3.7.0 Operating System: Windows 10 Enterprise (1909), 64-bit FireFox Version: 75.0 Add-on's Info (Enable/Disabled):

Amazon.co.uk 1.1 true amazon@search.mozilla.org Amazon.com 1.1 true amazondotcom@search.mozilla.org Bing 1.1 true bing@search.mozilla.org Containerise 3.7.0 true containerise@kinte.sh DuckDuckGo 1.0 true ddg@search.mozilla.org eBay 1.0 true ebay@search.mozilla.org Firefox Multi-Account Containers 6.2.3 true @testpilot-containers Google 1.0 true google@search.mozilla.org Tree Style Tab 3.4.8 true treestyletab@piro.sakura.ne.jp TST Colored Tabs 0.7 true tst-colored-tabs@murz TST Mouse Wheel and Double Click 1.5 true tst-wheel_and_double@dontpokebadgers.com TST-MiddleClick 1.1.0 true tst-middleclick@alexendris.com Twitter 1.0 true twitter@search.mozilla.org uBlock Origin 1.26.0 true uBlock0@raymondhill.net Wikipedia (en) 1.0 true wikipedia@search.mozilla.org

Actual Behaviour: The tab itself will go berserk! Flashing 'Default Container' & 'Existing Container', back and forth. Closing & re-opening.

Expected Behaviour: Before assigning 'Default Container' in a tab, check for existing container tabs.

Steps To Reproduce: 1) Open an existing container tab assigned in Multi Account Container (or any other container tab, even Temporary) 2) In Containerise, enable 'Default Container'. 3) Refresh the existing container tab.

LoveIsGrief commented 4 years ago

Hi,

another solution would be to use the multi account container API and check whether the URL has been assigned to a container there.

Otherwise, this is a dupe of #53

Solid-Ice8 commented 4 years ago

The issue I'm having is different from the one stated in #53. In that issue's case; Multi Account Container alone is enough to solve that issue. With that add-on, you can log into more than 2 accounts on any website as long as you don't assign them to a specific container tab.

You may have any 3 identical container tabs.

Example: Twitter1 - Gift - Green Twitter2 - Vacation - Blue Twitter3 - Glasses - Yellow

You can log into each container with 3 different accounts. As long as you DO NOT assign "www.twitter.com" into any of these container tabs. This is also why some users don't prefer to use the Twitter Container add-on when Multi Account Container installed.

I don't know what someone wants to do with 3 Twitter accounts, but some people may have more than 3 GMail accounts. This will work. There wouldn't be a need for Containerise in the first place (Sorry, no hard feelings; I'm still a new user of this add-on afterall).

What's the reason of a "Default Container"? It should act as a barrier; similar to "No Container" or "Temporary Container". That may be the case for Containerise too.

In Multi Account Container; the "Default" container is basically 'transparent' container. Nothing can be assigned to it and any unassociated sites, open link in new tab, middle click link; all these open in it as well. There's literally no container at all.

With Containrise, I've tested many sites I've never associated to; like Yahoo, Msn.etc.; all these do in fact open in a newly created "Default Container" (it never existed before) after refreshing/reloading/F5.

However, the problem lies here. I've also assigned GitHub.com to "Forums" container tab and at the same time; it will also attempt to add "Default Container" into this container tab. In other words, "Default Container" is being forced into "Forums" and that is a big no no, thus crashing the tab; alternating Default Container/Forums.

I've made my very first gif! Well, converted from video but, it worked. Quality isn't that good, but it turned out not too bad.