search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
411 stars 55 forks source link

fix issue where www.* hostnames don't work #139

Closed edwardgalligan closed 3 years ago

edwardgalligan commented 3 years ago

Fixes https://github.com/kintesh/containerise/issues/138

I'm not 100% sure this doesn't break other functionality though as I don't really understand why this replace() was there in the first place, and it seems to have been there from the beginning https://github.com/kintesh/containerise/blob/1eabe7b16bf3e1b411be349a1241257c19181fa1/src/webRequestListener.js#L12

If @kintesh has some insight into the reason for the replace(), that might help.

kintesh commented 3 years ago

@edwardgalligan. Originally, this extension only worked with top level domain names. Now that it supports subdomains using regex and glob patterns, I guess this is not needed. Like you said, I don't know if this will break anything. As for the #138, can they not use regex or glob matching?

edwardgalligan commented 3 years ago

can they not use regex or glob matching? -- @kintesh

Regex/glob matching does work, but clicking the + button in the Containerise UI doesn't generate a glob. It adds the current hostname as is (which, if it's a www.* hostname, doesn't currently work).

edwardgalligan commented 3 years ago

Fairly sure this also fixes https://github.com/kintesh/containerise/issues/136 and quite possibly https://github.com/kintesh/containerise/issues/141

donw146 commented 3 years ago

@kintesh When will this fix be released?

kintesh commented 3 years ago

@edwardgalligan Gonna merge this now and relese it over the weekend. It is very likely that this will break existing mappings for some but we'll have to see.