search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
408 stars 54 forks source link

Remove temporary tabs if keepOldTabs is true. Fixes #93 #144

Closed switz closed 3 years ago

switz commented 3 years ago

This fixes #93 .

It'll remove about:blank or about:newtab tabs temporary tabs when switching containers.

I can't promise it's a perfect solution as I'm not intimately familiar with the codebase, however, I tested it locally and it seemed to accomplish the task.

Let me know if you need me to make any changes, but I think this improves the keepOldTabs UX quite a bit. Thanks!

Addt'l info: I've been using this for a few hours and it's a huge improvement, haven't noticed any bugs yet. I'll follow up if I find any bugs.

switz commented 3 years ago

I've been running this for a few weeks and it works very well. Any plans to merge and release this?

muzzah commented 3 years ago

Would be great to have this released I have so many dead tabs lying around with the default container option enabled

rhclayto commented 3 years ago

Plus one on merging this.

muzzah commented 3 years ago

Ive actually moved to using https://github.com/stoically/temporary-containers Works a lot more stable and its logic with temporary tabs does not create these dangling tabs. Highly recommended