search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
408 stars 54 forks source link

TLD matching isn't using eTLD, mismatches *.co.uk #159

Open mook-as opened 3 years ago

mook-as commented 3 years ago

Hi, first, thanks for the extension! I've been using it for quite a while now.

I have a default container rule for ~{domain}.{tld}; however, on https://amazon.co.uk/, that generates a container name of ~co.uk, which isn't quite the desired behaviour. I think that should follow eTLD rules and result in amazon.co.uk, but I'm not sure.

Double checking the implementation, I can confirm that this is an issue from this extension and not part of Firefox.

Thanks!

Using containerise 3.9.0 on Firefox 88.

ethhics commented 3 years ago

Looks like adding a dependency can fix eTLD support: https://stackoverflow.com/a/61253586

O-DoC commented 2 years ago

Hi, DiD you have any update on this issue ? Still the same as OP here too. version 3.9.0 on FF 90.0.2 Thanks 👍🏽

rtrind commented 2 years ago

Also interested on this, it breaks most .com.br addresses and it would solve the need to create containers for one time login access.