Open dmorlitz opened 2 years ago
@kintesh , can you comment on this PR? I think it is a very useful feature.
Nathan has taken this feature beyond my implementation at https://github.com/nwg/containerise-ce It might be worth looking at his changes as well
On Sat, Jan 29, 2022 at 1:15 PM Milutin Jovanović @.***> wrote:
@kintesh https://github.com/kintesh , can you comment on this PR? I think it is a very useful feature.
— Reply to this email directly, view it on GitHub https://github.com/kintesh/containerise/pull/167#issuecomment-1024960991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3NKESEAJFXQZEBAOXBILTUYQVEBANCNFSM5H27USAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
@mikijov @dmorlitz I will have a look at this soon.
@mikijov @dmorlitz I will have a look at this soon.
Did you have a chance to check this PR? If not did you think about giving some of your contributors the right to merge and release new versions?
I have passed control of this code to someone else who has forked containerise at https://github.com/nwg/containerise-ce - because there didn’t seem to be active development here
Since Firefox brought out Total Cookie Protection, I have stopped using containers. Any code I contributed here is open for anyone to take over.
On Wed, Mar 8, 2023 at 7:38 AM WolfRevo @.***> wrote:
@mikijov https://github.com/mikijov @dmorlitz https://github.com/dmorlitz I will have a look at this soon.
Did you have a chance to check this PR? If not did you think about giving some of your contributors the right to merge and release new versions?
— Reply to this email directly, view it on GitHub https://github.com/kintesh/containerise/pull/167#issuecomment-1460092794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3NKEVP6JKUBVFOQ6ADRRLW3B4TZANCNFSM5H27USAA . You are receiving this because you were mentioned.Message ID: @.***>
I have passed control of this code to someone else who has forked containerise at https://github.com/nwg/containerise-ce - because there didn’t seem to be active development here Since Firefox brought out Total Cookie Protection, I have stopped using containers. Any code I contributed here is open for anyone to take over. … On Wed, Mar 8, 2023 at 7:38 AM WolfRevo @.> wrote: @mikijov https://github.com/mikijov @dmorlitz https://github.com/dmorlitz I will have a look at this soon. Did you have a chance to check this PR? If not did you think about giving some of your contributors the right to merge and release new versions? — Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3NKEVP6JKUBVFOQ6ADRRLW3B4TZANCNFSM5H27USAA . You are receiving this because you were mentioned.Message ID: @.>
Thx for clarification! Your argument is fair enough.
This pull request creates an "always open in current container" function - configured via the UI. The format of the configuration variable is a pipe (|) separated list of domain names which will always open in the current tab regardless of domain rules. This enables the same domain to open in multiple containers - and to support sites that must remain in the same container as the site that launched it - such as PayPal.
The configuration variable is used in a regex and each domain name must be followed by a / The code adds the ( and )/ to the regex.