kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
418 stars 53 forks source link

Catch keyword-based searches #43

Closed Reylak closed 5 years ago

Reylak commented 5 years ago

When using a smart keyword in the location bar to do a search, the used tab is not moved to the corresponding container, even if the tab is not in any container (I understand the behavior is expected if the tab is already in a container, as the container change also does not happen during normal navigation).

Reylak commented 5 years ago

I just realized it actually catches keyword searches, but only when there are two words in the search! For instance, with the search keyword "kw": "kw test" is not caught, but "kw double test" is caught.

ghost commented 5 years ago

I'm not observing this behavior and use keywords quite regularly. If this is still happening, ould you give an example:

please?

Reylak commented 5 years ago

The website is https://www.gamekult.com/. I set the keyword gk for the search in the main search bar you see at the top. Containerise rule is simply *.gamekult.com.

The thing is, visiting this website from a clean tab does not put the tab in the container, as if the rule was not triggered. Refreshing the page with F5 does not fix this behavior, however refreshing without the cache with Ctrl+F5 successfully triggers the rule, and the tab is moved to the dedicated container.

ghost commented 5 years ago

😮 I'll be damned, I reproduce it with gk test.

Thanks for the bug report @Reylak ! I'll get on this when I have time

kintesh commented 5 years ago

This should be closed. @Reylak Can you please check if everything is working as expected?

Reylak commented 5 years ago

Nice work, it works as expected on this website. Nice catch of this corner case, thank you!

EDIT: it works from both the keyword search and a simple visit from a clean tab by the way :)