search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
414 stars 53 forks source link

Updating entries leaves the old entry and creates a new one #45

Open ghost opened 5 years ago

ghost commented 5 years ago

Steps to reproduce

  1. Add an entry e.g something.com
  2. Save the entry
  3. Modify the entry e.g aaaa.something.com

Result

something.com and aaaa.something.com exist now.

Here's a video thereof.

ghost commented 5 years ago

Closed with #47

kintesh commented 5 years ago

@LoveIsGrief I'll have to pull out your change from next release. By clearning the storage, you'll lose other entries and only keep the the ones in view. This is due to my original bad implementation.

ghost commented 5 years ago

Woops, you're right. I didn't test for that.

businessBoris commented 5 years ago

@LoveIsGrief , did you have a chance to look at it again? Thank you.

ghost commented 5 years ago

@businessBoris it seemed like either a restructuring or a hack would be necessary and I don't have the will to invest that much time into that, sorry.

Maybe @kintesh could improve his original implementation. He might have a better idea what to do about it.