kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
414 stars 53 forks source link

CSVEditor: Fix delimiter bug (closes #57) #58

Closed ethhics closed 5 years ago

ethhics commented 5 years ago

This bug had a really simple cause: the code to split host and container assumed that there would be only one delimiter. Now that regex is in play, it's likely that whatever the delimiter is decided upon, it will be found in some host string.

The fix is to assume that the container name doesn't have the delimiter in it, and therefore the last element in the delimiter-split array is the container and everything before is the host.

I haven't tested this in the app but in the console it works.