kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
418 stars 53 forks source link

v3.1.0 breaks multi-account containers altogether #73

Closed dr4Ke closed 5 years ago

dr4Ke commented 5 years ago

Using the latest firefox, a completely new profile with "Containerise" and "Firefox Multi-Account Containers" (FMAC below) add-ons only, with no rule in "Containerise".

I'm facing two cumulative behaviors:

It keeps going until I disable one of the two add-ons.

I think it is the same cause than for #70, #71 and #72. I opened this new issue because I think it gives an easily reproducible case.

To reproduce:

If you want to go wild, tick "Remember my decision for this site".

benji1304 commented 5 years ago

Could this be causing the issue here? https://github.com/mozilla/contain-facebook/issues/469

I've rolled back Containerise to 3.0.1 and the issue no longer presents.

bitstreamout commented 5 years ago

I see this also for amazon container open inifinte tabs in loop ... also search in in duckduckgo open two tabs from search engines where the first is a standard tabg and the second is the a personal tab (as I had configured this duckduckgo) .... only the google container works flawless

bitstreamout commented 5 years ago

The only workaround is to add some amazon domains to avoid those loops ... seems that "Containerise" fights against "Amazon Container" ... I guess that this also is the cause for the loop with "Facebook Container" and similar addons ... and as I had already some google domains configured in "Containerise" the fight with "Google Container" does not happen (as long as I do not access an unkown google domain)

benji1304 commented 5 years ago

Rolling back to a previous version for the moment seems like the easiest workaround

edit: With the link to previous versions https://addons.mozilla.org/en-GB/firefox/addon/containerise/versions/

gbdlin commented 5 years ago

When rolling back to previous versions, remember to disable automatic updates for this addon.

dr4Ke commented 5 years ago

Could this be causing the issue here? mozilla/contain-facebook#469

Most probably.

dr4Ke commented 5 years ago

The issue is that Containerise systematically opens undefined sites in a "No container" tab, while any other add-on tries to open it in a specific container. The most spectacular effect is with add-ons that automatically do so.

kintesh commented 5 years ago

See https://github.com/kintesh/containerise/issues/70#issuecomment-509736333

lkfbr commented 5 years ago

Actually, the comment in #70 is irrelevant here. The change caused problems for me with the following scenarios:

So no interaction with other extensions was involved.

stoically commented 5 years ago

The change mentioned in the linked comment is about no longer allowing any url to load in any container that isn't assigned with containerise - also causing your issues.

kintesh commented 5 years ago

All the changes of v3.1.0 are reverted in v3.2.0

Drizzt321 commented 5 years ago

@kintesh I've got v3.2.0 installed and it's opening up infinite new tabs. Although if I close the newest one to open it stops the opening and I can close them all, or if I close the window.

ghost commented 5 years ago

@Drizzt321 Could you open a new bug for that and describe what you're doing? I can't observe this behavior here