search

kintesh / containerise

Firefox extension to automatically open websites in a container
MIT License
418 stars 53 forks source link

Compatibility with TC after unmapped url isolation change #74

Closed stoically closed 5 years ago

stoically commented 5 years ago

Here's a possible fix for the incompatbility with TC introduced in #63. Checks for tmp container before opening unmapped urls in the default container - otherwise we end up with endlessly spawning tabs. Performance-wise it's not too bad, since sendMessage checks for the existence of the receiving end first, which is really fast. Did the same in TC for MAC a long time without problems, until introducing the management permission.

Fixes https://github.com/kintesh/containerise/issues/70, https://github.com/stoically/temporary-containers/issues/287#issuecomment-509446968, https://github.com/stoically/temporary-containers/issues/286#issuecomment-509501266

You could also look into the MAC API to solve #73.

Personally I'd make the feature optional as suggested in #71 - and default-off.

stoically commented 5 years ago

According to https://github.com/kintesh/containerise/issues/70#issuecomment-509736333 the "unmapped urls isolation" change gets reverted, so this PR is obsolete.