Additionally listen to tab updates to catch events that slip by webrequests

kintesh / containerise

Firefox extension to automatically open websites in a container

MIT License

418 stars 53 forks source link

Additionally listen to tab updates to catch events that slip by webrequests #87

Closed ghost closed 5 years ago

ghost commented 5 years ago

For some reason some keyword searches like https://www.gamekult.com/rechercher-jeu.html?q=%s actually aren't caught. They pass through a javascript file e.g https://www.gamekult.com/sw.js instead which does the XHR request and presents the results. For whatever reason firefox doesn't catch that in the webrequest listeners (possibly a bug?), so we're forced to look at the changing URL of the tab and react to that.

Related to #43 - Catch keyword-based searches

kintesh commented 5 years ago

Could this be due to how service workers work? I was under the impression that if a service worker is registered, it will get all requets made from the domain.

ghost commented 5 years ago

I'm not sure. I wasn't aware of that mechanic :thinking:

Edit: I just saw that you merged it :smile:

Thanks