[textConnect] Feature update to resolve issue with delimiters appending to empty fields

kintone-samples / plugin-samples

55 stars 155 forks source link

[textConnect] Feature update to resolve issue with delimiters appending to empty fields #135

Closed ghost closed 6 years ago

ghost commented 6 years ago

Changes made to TextConnect Plugin

When TextConnect is asked to combine an empty field, it does not add an additional delimiter to the resolved field.

example:

Fields user wants to combine: First Name:[Shashank] Middle Name:[] Last Name:[Guduru]

User selected delimiter: ","

What system does now: Resolved Field: [Shashank,Guduru]

What System did previously: Resolve Field: [Shashank,,Guduru]

The extra comma problem is solved.

ghost commented 6 years ago

Hi @will-yama Sorry for the delay. I just updated the branch with the changes you requested. I also ran eslint-config-kintone on desktop.js and config.js and made the necessary changes.

ghost commented 6 years ago

@will-yama I got my eslint-config-kintone settings set up properly with the help of @leohliao. I moved the 'use strict' commands inside the immediate function. Please let me know if any other changes need to be made.

will-yama commented 6 years ago

LGTM Thanks for the fixes!