search

kinvolk-archives / lokomotive-kubernetes

Lokomotive is a 100% open-source Kubernetes distribution from the folks at Kinvolk
https://kinvolk.io
MIT License
144 stars 20 forks source link

Clarifiy unexpected Packet private CIDR behaviour #163

Closed DGollings closed 4 years ago

DGollings commented 4 years ago

Attempts to address or at least mitigate issue #159

DGollings commented 4 years ago

Also, please update the commit titles to reflect the changes, (not just the unsuful gihub default of "Update ", squash them if possible :)

I'm more of a 'never rewrite (git) history' type of guy, so never bothered to learn how to either rename a commit or squash it, could you point me to the FM and I'll figure it out :)

rata commented 4 years ago

@DGollings no worries, just add a different commit then and I can squash on merge :)

DGollings commented 4 years ago

Quite the discussion: https://softwareengineering.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests

I can see the pro/cons, but trunk based development ftw (?)

done, ish, removed what I think was a duplicate Note: (edit: although I agree my original commit message was useless)