search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

Remove MetalLB autodiscovery workarounds #1011

Open johananl opened 4 years ago

johananl commented 4 years ago

Currently we are doing some wiring in Terraform to gather BGP metadata from Packet and pass it to MetalLB via node labels:

https://github.com/kinvolk/lokomotive/blob/3008e5a1cd7cc478482a7c2b365e8a02ae25fc95/assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/cl/worker.yaml.tmpl#L89-L91

https://github.com/kinvolk/lokomotive/blob/3008e5a1cd7cc478482a7c2b365e8a02ae25fc95/assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/cl/worker.yaml.tmpl#L114-L116

https://github.com/kinvolk/lokomotive/blob/3008e5a1cd7cc478482a7c2b365e8a02ae25fc95/assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/workers.tf#L52-L57

https://github.com/kinvolk/lokomotive/blob/3008e5a1cd7cc478482a7c2b365e8a02ae25fc95/assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/workers.tf#L74

The Packet CCM is supposed to support enriching Node objects directly with BGP metadata using k8s annotations. We should look into using this mechanism for BGP peer autodiscovery and get rid of all of the above.

johananl commented 4 years ago

Following https://github.com/kinvolk/lokomotive/pull/1010 we should also get rid of wait-for-bgp.service