search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

Switch etcd logger to zap #1067

Open invidian opened 4 years ago

invidian commented 4 years ago

As default capnslog is deprecated. This causes following log to be present:

Oct 12 13:14:07 tink-controller-0 96c53009bb40[846]: 2020-10-12 13:14:07.754615 W | pkg/flags: unrecognized environment variable ETCD_USER=etcd
Oct 12 13:14:07 tink-controller-0 96c53009bb40[846]: [WARNING] Deprecated '--logger=capnslog' flag is set; use '--logger=zap' flag instead
Oct 12 13:14:07 tink-controller-0 96c53009bb40[846]: 2020-10-12 13:14:07.754655 I | etcdmain: etcd Version: 3.4.13
Oct 12 13:14:07 tink-controller-0 96c53009bb40[846]: 2020-10-12 13:14:07.754682 I | etcdmain: Git SHA: ae9734ed2
Oct 12 13:14:07 tink-controller-0 96c53009bb40[846]: 2020-10-12 13:14:07.754692 I | etcdmain: Go Version: go1.12.1
karlskewes commented 3 years ago

Looks like for 3.5 it will switch to zap and capnslog will be removed - https://etcd.io/docs/v3.3.12/upgrades/upgrade_3_5/ I couldn't see when 3.5 is expected to be released.

We could add to env vars file now: https://etcd.io/docs/v3.4.0/op-guide/configuration/#logging-flags Then potentially remove some time later if/when the flag is removed.