search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

Figure out how to run e2e tests for PRs outside the repository #1247

Open invidian opened 3 years ago

invidian commented 3 years ago

Current situation Recently, we've got some PRs from outside contributors and right now we are not able to run e2e tests on them, as we only allow them for PRs originating from this repository.

Impact Having no CI for external contributions may affect the quality or impact contributing community, as process for merging those PRs will be slower, as it will require manual testing. Or we will have to take over all PRs and create replacements.

Ideal future situation We should have a way, similar to ok-to-test label from Kubernetes repositories, which enables us to allow running CI for a given commits for external contributors.

invidian commented 3 years ago

I think we could use something like https://github.com/colstrom/concourse-github-status to run tests for all pushes to this repository. This would include all feature branches and master branch.

It will also be nicer to what we currently have, as we will have a status for merge commits in the master branch.

This way, if someone opens a PR from fork, we simply need to pull it via git pr or with gh pr checkout and then re-push the branch to main repository.

knrt10 commented 3 years ago

ideal situation will be handled by bot, once we decide to move forward with it

invidian commented 3 years ago

We could also run the CI for PRs which are approved from external contributors, as GitHub plugin we currently use for Concourse supports that. We would combine that with automatic dismissal of approvals on push then, so job only runs on code which has been approved.