search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

metallb: Convert to Helm chart and update to latest version #1555

Closed knrt10 closed 3 years ago

knrt10 commented 3 years ago

Signed-off-by: knrt10 kautilya@kinvolk.io

Part of #1443

knrt10 commented 3 years ago

@ipochi yes this is chart from upstream. I have only made necessary changes for the chart to work. Do you mean I should change pkg/ files in a different commit?

ipochi commented 3 years ago

@ipochi yes this is chart from upstream. I have only made necessary changes for the chart to work. Do you mean I should change pkg/ files in a different commit?

Yes, I mean upstream helm chart and Lokomotive changes in separate commit.

Are there Lokomotive specifi changes in the assets/charts/components/metallb ? If so then separate commits would make sense, else not.

knrt10 commented 3 years ago

I have not tested the upgrade path, only installation. Will test it

knrt10 commented 3 years ago

Checked the upgrade. Works fine. There was no downtime. I tried by deploying httpbin and refreshing it while upgrade. Not really sure if it's the correct way