Consider testing `cluster apply` on CI

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk

https://kinvolk.io/lokomotive-kubernetes/

Apache License 2.0

321 stars 49 forks source link

Consider testing `cluster apply` on CI #165

Open iaguis opened 4 years ago

iaguis commented 4 years ago

In https://github.com/kinvolk/lokomotive/issues/160 we fixed a bug that happened on lokoctl cluster apply but not on lokoctl cluster apply --skip-components + lokoctl component apply like we run on CI.

We should consider running lokoctl cluster apply on CI.

invidian commented 4 years ago

IMO that should be covered by unit tests and CI should use any method to install things, not all of them.

surajssd commented 4 years ago

This is done now, no?

invidian commented 4 years ago

This is done now, no?

No, why?

surajssd commented 4 years ago

Ah I see it now because lokoctl apply started working and I thought it is tested on CI as well!