Remove uses of kubernetes.io/ingress.class deprecated annotation

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk

https://kinvolk.io/lokomotive-kubernetes/

Apache License 2.0

321 stars 49 forks source link

Remove uses of kubernetes.io/ingress.class deprecated annotation #275

Open rata opened 4 years ago

rata commented 4 years ago

Kubernetes 1.18 deprecated that annotation as explained here: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#extending-ingress-with-and-replacing-a-deprecated-annotation-with-ingressclass

We should stop using it in our components now that it is deprecated.

knrt10 commented 4 years ago

Should we change it to projectcontour.io/ingress.class because as per contour latest docs they suggest that https://projectcontour.io/docs/v1.9.0/annotations/. But as per kubernetes docs, we should add IngressClass resource https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/

What do you guys think? cc @invidian

invidian commented 4 years ago

Perhaps ingressClassName field in Ingress objects v1 is backwards-compatible with annotations?