search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

Merge components rook && rook-ceph | openebs-operator && openebs-storage-class #518

Open surajssd opened 4 years ago

surajssd commented 4 years ago

Above pairs can be merged into one now because they essentially deal with the same thing.

This segregation was done during the times when the backend for lokoctl components install/apply ... was not helm. And the limitation with that was, there was no mechanism which could help us wait for certain CRD to be reconciled in the apiserver and then install corresponding CRs.

Due to that limitation the component installation was flaky and would fail arbitrarily. But now we don't have these limitations and it is time to merge them into one.

invidian commented 4 years ago

While I agree in OpenEBS case, in case of Rook, one may want to use just Rook and use it for example for Cassandra, not Ceph. So I'd leave it separate OR I'd make Ceph optional if we merge them.

surajssd commented 4 years ago

That can be solved by having sub-blocks. There is no exclusivity with using rook. You can use multiple storage backends at the same time.

invidian commented 4 years ago

With #516, the split would allow deploying multiple clusters. But I agree we could have it under a block. Though we need to do that from the beginning then, otherwise it will be more difficult to add support for other storage backends.