Open johananl opened 4 years ago
Another problem:
cluster "aws" {
...
cluster_name = "johannes-test"
worker_pool "johannes-test-p1" { ... }
}
The above config results in instances with the following name: johannes-test-johannes-test-p1-worker
. I cannot omit the johannes-test-
prefix in worker_pool
because then the ASG is named p1
.
The reason for reverting was avoiding breaking upgrades. Maybe we can find a way to make this change in two phases across two releases without breaking things? thinking
One way would be to add new autoscaling group with new name and then resize old group to 0, but we would have to make sure that the operation is done gracefully. Then, in the next release we can simply remove old group.
In https://github.com/kinvolk/lokomotive/pull/638/commits/20b7b696a61ba6ec706140feeaae6c25dfb3dfae we reverted a change which prefixed an auto scaling group name with the cluster name. Having the prefix has the following advantages:
The reason for reverting was avoiding breaking upgrades. Maybe we can find a way to make this change in two phases across two releases without breaking things? :thinking: