External DNS asks Route53 Zone ID which is not used anywhere

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk

https://kinvolk.io/lokomotive-kubernetes/

Apache License 2.0

321 stars 49 forks source link

External DNS asks Route53 Zone ID which is not used anywhere #719

Open surajssd opened 4 years ago

surajssd commented 4 years ago

We removed the need for Route53 zone ID for the Packet cluster installation. This was a huge plus in UX but then we ask it for External DNS config which has negated the improvement done.

johananl commented 3 years ago

Sounds like this is the place for the infra<>components mechanism discussed in https://github.com/kinvolk/lokomotive/issues/499. We could pass the zone ID from the Terraform data source to the component somehow.

surajssd commented 3 years ago

So it turns out that we ask for zone_id but it ain't used anywhere.

$ grep ZoneID pkg/components/external-dns/
pkg/components/external-dns/component.go
70:     ZoneID          string `hcl:"zone_id"`