search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
321 stars 49 forks source link

Source Prometheus Operator chart from new place #745

Open surajssd opened 4 years ago

surajssd commented 4 years ago

We use Prometheus Operator helm chart from the charts repo which is going to be deprecated in November. More info about it is here: https://github.com/helm/charts#deprecation-timeline.

Now I think it makes sense to piece together the sub-components of Prometheus Operator and maintain a chart on our own.

invidian commented 4 years ago

I'm 99% sure someone else will pick up the maintenance of this helm chart, as it is widely used. Should we ask in https://github.com/coreos/prometheus-operator perhaps? I'd really like avoid maintaining such a large helm chart.

Edit: the discussion is happening here: https://github.com/coreos/prometheus-operator/issues/3169.

surajssd commented 4 years ago

The maintainers of the project prometheus-operator and the helm chart prometheus-operator are different.

surajssd commented 4 years ago

We can use the bitnami chart but it does not provide grafana we might need to add that manually. https://hub.helm.sh/charts/bitnami/prometheus-operator the source is at https://github.com/bitnami/charts/tree/master/bitnami/prometheus-operator

invidian commented 4 years ago

The maintainers of the project prometheus-operator and the helm chart prometheus-operator are different.

Right now, yes, but I think eventually they should be at least governed by the same people. I think we should use the upstream chart until it's clear that it has been deprecated and will no longer be supported.

Right now only the stable helm repo is deprecated, not the charts itself (though some of them are abandoned).

surajssd commented 4 years ago

Right now, yes, but I think eventually they should be at least governed by the same people. I think we should use the upstream chart until it's clear that it has been deprecated and will no longer be supported.

Most folks who maintain the project prometheus-operator don't use Helm for app management hence they don't feel comfortable in maintaining a helm chart themselves. But yes we should keep track of that issue.

invidian commented 4 years ago

I think we can close/rename this issue, as the chart will be now maintained in https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack, so we should migrate to it.

invidian commented 4 years ago

WIP migration path: https://github.com/prometheus-community/helm-charts/pull/119