search

kinvolk / racker

rack provisioning utility for Kinvolk projects
Apache License 2.0
14 stars 3 forks source link

Velero setup #40

Closed joaquimrocha closed 3 years ago

joaquimrocha commented 3 years ago

TBD

ipochi commented 3 years ago

@joaquimrocha

I'd rather have a velero.lokocfg file or more specifically a separate lokocfg file for each component. Much easier and avoids having large single lokocfg file.

Secondly, we need to include velero binary in the racker installation similar to terraform and kubelet. Lokomotive supports Velero v1.5.4 (If I am not mistaken)

ipochi commented 3 years ago

@joaquimrocha

In line https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L559 and https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L577

we are installing the cluster and providing the --skip-components flag. So if the cluster is created, this PR will only go ahead and create a velero config or for that matter any component details we ask in the wizard from the user.

The installation of the said component would be a manual step on the user by doing lokoctl components install and then it will install all the configured components in the directory.

To avoid the manual step, this PR should also include the changes to the above lines by removing the --skip-components flag.

pothos commented 3 years ago

@joaquimrocha

In line

https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L559 and

https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L577

we are installing the cluster and providing the --skip-components flag. So if the cluster is created, this PR will only go ahead and create a velero config or for that matter any component details we ask in the wizard from the user.

The installation of the said component would be a manual step on the user by doing lokoctl components install and then it will install all the configured components in the directory.

To avoid the manual step, this PR should also include the changes to the above lines by removing the --skip-components flag.

No, components are installed as last step: https://github.com/kinvolk/racker/blob/main/bootstrap/prepare.sh#L560

ipochi commented 3 years ago

@joaquimrocha

In line

https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L559 and

https://github.com/kinvolk/racker/blob/818fbfb19cf104d834a2fa2887781b35d36e22ca/bootstrap/prepare.sh#L577

we are installing the cluster and providing the --skip-components flag. So if the cluster is created, this PR will only go ahead and create a velero config or for that matter any component details we ask in the wizard from the user.

The installation of the said component would be a manual step on the user by doing lokoctl components install and then it will install all the configured components in the directory.

To avoid the manual step, this PR should also include the changes to the above lines by removing the --skip-components flag.

No, components are installed as last step: https://github.com/kinvolk/racker/blob/main/bootstrap/prepare.sh#L560

Ah, I didn't see that.

Thanks for pointing out @pothos