search

kinvolk / racker

rack provisioning utility for Kinvolk projects
Apache License 2.0
14 stars 3 forks source link

Improve UX for getting the IP addresses #41

Closed joaquimrocha closed 3 years ago

joaquimrocha commented 3 years ago

@pothos , This is the work I did today around the improvement for the IP address UX we talked about on Slack.

The part about prefilling (setting the default for the manual IP address option) is still to be added.

(There's an extra commit which in the wizard, which comes fromt he velero_setup branch, but it's better to keep it for now)

pothos commented 3 years ago

It's in a functional state now :)

pothos commented 3 years ago

A small problem is that there are spaces inserted into the editor as prefix for the first line but I haven't debugged it yet. Anyway it can also be fixed later.

pothos commented 3 years ago

A test run was successful

joaquimrocha commented 3 years ago

@pothos , Continuing what we talked about the flag help message on Slack, I think it's a bit overkill to ship a separate template/example file (and reusing the one we already have is not good because it's written in the context of using the wizard). So my fixup commit here changes the message a bit and mentions the docs URL that we still need to supply later.

I will make this a draft PR just so we don't accidentally merge the fixup commit without squashing it, but feel free to squash & merge on Monday.