search

kinvolk / racker

rack provisioning utility for Kinvolk projects
Apache License 2.0
14 stars 3 forks source link

[RFE] Suggest to use non case sesitive comparison for nodes.csv mac addresses #95

Open TheApeMachine opened 3 years ago

TheApeMachine commented 3 years ago

Current situation

I was setting things up and got an error on racker factory check about it not being able to determine PXE interface by looking at the columns of mac addresses. Looking at the code I was able to figure out what I was doing wrong, however I used capitals because that is how the are shown to me by various tools (not all though).

Impact

Not very high, likely it is a convention to use lower-casing that I am not aware about.

Ideal future situation

use Go's strings.EqualFold here to remove the likelihood of it happening for other people.

**Implementation options

See above.

Additional information

Everything is working out great so far.

pothos commented 3 years ago

Thanks for creating the issue and giving feedback! Yes, a simple conversion to lowercase with tr in the pipe would prevent this (There are some places to do this change, though).