kinyelo / vosao

Automatically exported from code.google.com/p/vosao
GNU Lesser General Public License v2.1
1 stars 2 forks source link

language bug #363

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
when switch language to zh_CN or other not 2 character languages, it handle the 
wrong url.

the vasao.js is wrong.
change the following function.

Vosao.changeLanguage = function(lang) {
    var url = location.href.replace('#','');
    var langIndex = url.indexOf('language=');
    var sign = location.search.indexOf('?') == -1 ? '?' : '&';
    if (langIndex > 0) {
        url = url.substr(0, langIndex)+'language='+lang;
        var langAfter=url.substr(langIndex+1);
        var langAndIndex=langAfter.indexOf('&');
        url = url.substr(0, langIndex);
        if(langAndIndex>0){
            url=url+langAfter.substr(langAndIndex+1);
        }
        if(url.indexOf('&')<0){
            sign='';
        }
    }
    url = url + sign + 'language=' + lang;
    location.href = url;
};

Original issue reported on code.google.com by akand...@gmail.com on 10 Oct 2010 at 2:04

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
should be:
Vosao.changeLanguage = function(lang) {
    var url = location.href.replace('#','');
    var langIndex = url.indexOf('language=');
    var sign = location.search.indexOf('?') == -1 ? '?' : '&';
    if (langIndex > 0) {
        var langAfter=url.substr(langIndex+1);
        var langAndIndex=langAfter.indexOf('&');
        url = url.substr(0, langIndex)+'language=' + lang;
        if(langAndIndex>0){
            url=url+langAfter.substr(langAndIndex+1);
        }
        if(url.indexOf('&')<0){
            sign='';
        }
    }else{
        url = url + sign + 'language=' + lang;
    }
    location.href = url;
};

Original comment by akand...@gmail.com on 10 Oct 2010 at 2:31

GoogleCodeExporter commented 9 years ago
Fixed r931.

Original comment by kinyelo@gmail.com on 26 Nov 2010 at 5:26