Closed danqing closed 10 years ago
which grouped table view does this happen for
Every one I think. Facility hours, settings, etc.
Not "real" grouped table view. They are faked by a background.
What exactly do you mean by moving it higher? Should the spacing between the label and the fake grouped table view be bigger or smaller? I'll replace all instances with a constant in YMTheme instead of hard coded spacing.
@ik
They should be vertically centered. Now the space between text and the upper divider is larger than that between the text and the lower divider.
I refactored the top label spacing and reduced it by 6px, you can change the exact spacing in YMTheme. Vertical alignment might actually look odd since right now the label is neatly aligned with the labels in the grouped table view.
No, that sounds like the wrong change. I meant the labels within each cell, not the group header. They are not vertically centered within the cells.
Okay the refactoring makes sense anyways and also looks slightly better so that should still be incorporated.
Can you provide a screenshot and point out what visible change it introduces? Thanks!
Note to self: facility hours, calendar, settings
901501e
Grouped table view means the one with a custom border.
I think the label is not vertically centered. Please use your judgement to vertically center them ;)