Duct Tape + Do While + Zero Cost Card

kiooeht / Hubris

Expansion mod for Slay the Spire.

6 stars 9 forks source link

Duct Tape + Do While + Zero Cost Card #2

Open mikeynap opened 6 years ago

mikeynap commented 6 years ago

Action: Use Duct Tape on Do While + Claw, play duct tape card, assume n energy. Expects: Claw to be played n+1 times Result: Duct Tape plays infinitely many times (claws to death).

DoWhile loops itself, but since the first instance of claw is always free, it never terminates.

kiooeht commented 6 years ago

I just tested this with a Do While+ and Claw.

With 3 energy:

Play Duct Tape (Do While+ and Clay), 0 cost.
- Do While+ happens.
- Claw happens, deals 3 damage.
Have 3 energy.
Duct Tape gets replayed at +1 cost, 1 cost.
- Do While+ happens
- Claw happens, deals 3 damage
Have 2 energy.
Duct Tape gets replayed, 1 cost.
- Do While+ happens
- Claw happens, deals 3 damage
Have 1 energy.
Duct Tape gets replayed, 1 cost.
- Do While+ happens
- Claw happens, deals 3 damage
Have 0 energy.
Duct Tape can't be played for 1 cost; Stop.

Claw played 3+1 times. Total damage: 12.

mikeynap commented 6 years ago

Well this might be a confounding bug -- but I just reproduced it (differently) with AstralHammer (not sure if that mattered).

I played DoWhile + Claw on the awaken one. After he died, it kept do-whiling indefinitely. I had to save and quit. Here's a screen shot of it in action: https://ibb.co/nopE6p

The astralHammer interaction makes sense I believe -- it keeps setting the cost of the card that doWhile tries to increase back to zero.

Not sure why you can't reproduce the original bug... I'm pretty sure I didn't have AstralHammer during it.

mikeynap commented 6 years ago

I implemented a fix and was going to put out a PR, but when I went to test the fix, i noticed that all the images in your resources/ directory download as 0 byte files which are unopenable and empty. It compiles fine, but fails when trying to load the garbage file.

They are corrupt if you download the zip or do a git clone, but not when you manually go and view/saveas them on github.com.

It's quite strange haha. If you ever wanted to manually zip the resources folder and give me a link I'd help out with bug fixes and what not (if you'd like).

kiooeht commented 6 years ago

They're not corrupt. I'm using Git LFS for all the resource files. See: https://help.github.com/articles/duplicating-a-repository/#mirroring-a-repository-that-contains-git-large-file-storage-objects

mikeynap commented 6 years ago

Ahhhh, I've never heard of that. Thanks for the link!