kiooeht / ModTheSpire

External mod loader for Slay The Spire
MIT License
415 stars 87 forks source link

Update Kotlin Version #202

Open Kobting opened 1 year ago

Kobting commented 1 year ago

Edit: After writing this I realize that if they are binary compatible there is nothing stopping someone from writing a mod with 1.7.20 and it should work fine with the Kotlin version provided by ModTheSpire.

Suggestion:

ModTheSpire should update the Kotlin version it includes to 1.7.20

The Kotlin version (1.4.10) shipped with ModTheSpire is 3 years old at this point. This excludes the possible use of new language features or libraries that would be helpful when writing a mod in Kotlin.

From looking at all the compatibility guides from 1.4 up to 1.9 it looks like it should be safe to update to version 1.7.20

Reasoning:

There are no stated binary compatibility issues between 1.4.10 and 1.7.20. The first binary compatibility issue happens in 1.8 (link).

Downside:

Anyone using ModTheSpire to update/create a mod will need to update the version of Kotlin they use and fix any source compatibility issues that happen between 1.4.10 and 1.7.20.