search

kiorky / croniter

MIT License
410 stars 40 forks source link

Clarify expression alias logic #110

Closed evanpurkhiser closed 1 week ago

evanpurkhiser commented 1 month ago

Instead of using tuple indexing use a namedtuple mapped from the expression aliases. This makes readability / understanding of this logic a little easier.

evanpurkhiser commented 1 month ago

Updated to fix remove the conflict

kiorky commented 1 month ago

Updated to fix remove the conflict

oups, the other pr i just merged broke it again :( :) .

evanpurkhiser commented 1 month ago

I'll get it fixed after I get the black formatting done :)

evanpurkhiser commented 1 week ago

Going to close this one out since this one's a bit controversial.

Feel free to pull from parts of it though if you'd like!

kiorky commented 1 week ago

Going to close this one out since this one's a bit controversial.

Feel free to pull from parts of it though if you'd like!

When i started to review #136 & & #135, what i saw is that it will be hard for someone else to do the relevant changes and so i started to do it myself as some spaghetti code that needs to be removed to implement clearly DST :-/.

TBH, i though i could finish DST rework, i have NOW a large diff which is on the go locally, but is not finished yet.

I hope to finish that soon with a better state that it is now.