kiorky / croniter

MIT License
410 stars 40 forks source link

Drop support for old Pythons; modernize & repair CI #93

Closed akx closed 1 month ago

akx commented 1 month ago

Since this changes the supported Python versions, I think this would be a semver-major change. I'm not sure if croniter is semver versioned.

Please see https://github.com/akx/croniter/pull/1 for the CI passing :)

kiorky commented 1 month ago

not ok for dropping support, we still support from python 2.6

akx commented 1 month ago

we still support from python 2.6

Yes, so far. As I said, this would be a semver-major version bump. Is there a reason to support Python 2.x going forward? Python 2.6 has been EOL for 10 years, Python 2.7 has been EOL for 4 years.

I can of course change this PR to not change the version requirements. However, looks like this package hasn't been CI tested on Python 2.7 since April 2023 and Python 2.6 since February 2020, so unless someone is manually testing on those versions of Python, there's really no guarantees. (As it is, testing locally on Python 2.7.18, there are 6 failing tests. I have no easy way of installing Python 2.6 on my machine.)

kiorky commented 1 month ago

Yes i know some project still use it from py2.

akx commented 1 month ago

Yes i know some project still use it from py2.

Okay. But those projects won't break if versions 4.0+ of croniter only support still-supported versions of Python.

In any case, see #94 for a PR that makes the current version's tests actually pass on Python 2.7 again.

akx commented 1 month ago

So @kiorky, should I just close this PR?

kiorky commented 1 month ago

I'm already taking bits of this PR to merge them by myself, a lot of thanks for all the ideas, though. I cant take it as is as i want to merge along things i had to do to modernize other things due for a long time, and this to be overall coherent. Look in the following days (i hope today, but not sure will have time to finish it :). If you still see some minor points that you want in, you can then rebase this PR, that's why i didn't closed it

In all cases, i'll poke you when done.

And again, really, thanks for the ideas and you will be quoted in next changelog as-is :) !

kiorky commented 1 month ago

Feel free to rebase / add something else you would find interresting.

Thanks !