search

kipcole9 / money_sql

Money functions for the serialization of a money data type in Elixir
Other
27 stars 18 forks source link

Fixed the SQL functions drop names and order #26

Closed GRoguelon closed 1 year ago

GRoguelon commented 1 year ago

Hi,

I recently installed the package and I noticed that the names of the drop functions for sum don't match with the create functions.

In addition, I believe the down/0 migration function should be in the opposite order of the up/0 migration function (first created, last destroyed).

Regards,

kipcole9 commented 1 year ago

Thanks again, much appreciated.

kipcole9 commented 1 year ago

Note that the migrations in the repo aren't part of the published package (a dev needs to generate their own migrations using the mix tasks of course) but I appreciate you making the format changes.