Delete additional Ecto.Schema options when loading

kipcole9 / money_sql

Money functions for the serialization of a money data type in Elixir

Other

28 stars 18 forks source link

Delete additional Ecto.Schema options when loading #40

Closed axelclark closed 11 months ago

axelclark commented 11 months ago

Problem: I was attempting to rename one of my fields with a Money.Ecto.Composite.Type while keeping the source column in the db the same, following this strategy.

However, the change caused my tests to fail because the Money struct loaded from the db had the source: :db_col in the format_options.

Proposed Solution: Deletes additional Ecto.Schema.field/3 options so they don't get loaded as format_options.

kipcole9 commented 11 months ago

Thanks much for the PR, greatly appreciated.

kipcole9 commented 11 months ago

I've published ex_money_sql version 1.10.2 with the following changelog entry:

Bug Fixes

Don't propagate some Ecto schema fields in Money.Ecto.Composite.Type.init/2. This change deletes additional Ecto.Schema.field/3 options so they don't get loaded as format_options. Thanks to @axelclark for the PR. Closes #40.
Fix Changelog headings and whitespace. Thanks to @c4710n for the PR. Closes #39.

Thanks again for the PR.