search

kipoi / models

Model zoo for genomics
http://kipoi.org
MIT License
163 stars 58 forks source link

Adjust APARENT model #293

Closed Hoeze closed 2 years ago

Hoeze commented 2 years ago
Hoeze commented 2 years ago

@haimasree How can the tests pass here when the expected predictions are nonsense?

haimasree commented 2 years ago

@haimasree How can the tests pass here when the expected predictions are nonsense?

Sorry dont know what you mean. In general kipoi test <model> --source=kipoi checks for three things -

  1. Whether the model specific conda environment can be created and activated successfully (which runs fine here since the dependencies did not change)
  2. Whether the data scheme that the dataloader outputs and the model expects match or not
  3. Optionally, if there is a test field in model.yaml the predictions in the h5 file is compared with the prediction produced by the the model. In this case only site_probabilities satisfies the criteria. This is the code which will test the model.

Do you suspect a bug here?

Hoeze commented 2 years ago

Thanks for the explanation @haimasree :+1:

Do you suspect a bug here?

No, I was confused because the predictions definitely changed since last time. I just did not see that there is no test field in the veff part :facepalm:

Overall I think it looks good. Let me know if I can merge.

Feel free to merge then :+1: