search

kipoi / models

Model zoo for genomics
http://kipoi.org
MIT License
163 stars 58 forks source link

DeepLiver models #357

Closed cbravo93 closed 1 year ago

cbravo93 commented 1 year ago

Hi!

I would like to add the DeepLiver models to the zoo. You can find the preprint describing the models at https://www.biorxiv.org/content/10.1101/2022.12.08.519575v1

Since I built the model using the internal keras from tensorflow (keras=2.2.4-tf, tensorflow=1.15), I had to add my own model class. It is exactly the same as kipoi's KerasModel, but using tensorflow.keras instead of keras for the imports.

Local tests have been successful, let me know if more information is needed!

C

bytewife commented 1 year ago

Hey C,

Just looking at this now, sorry about the delay! Looks good- let's see if the tests pass again

bytewife commented 1 year ago

Ah hold on for a second- this test failure is related to other changes in the repo! Let me take a look at them

cbravo93 commented 1 year ago

Thanks for taking a look! Let me know if I need to update anything :)

bytewife commented 1 year ago

Alright the tests are fixed now, should be good to go!