search

kippnorcal / google_classroom

Google Classroom Data Pipeline
GNU General Public License v3.0
23 stars 9 forks source link

Add additional course statuses to Courses Endpoint #95

Closed dchess closed 4 years ago

dchess commented 4 years ago

@zkagin When a course is archived in Google Classroom it doesn't get pulled by the API. This currently only pulls active.

dchess commented 4 years ago

I think this can be fixed with a simple change to the status list in: https://github.com/kipp-bayarea/google_classroom/blob/2310e846093415cddda96987558409298d4df056/google_classroom/api.py#L407-L412

dchess commented 4 years ago

It will also likely require a change to the course id pull to filter on active status though: https://github.com/kipp-bayarea/google_classroom/blob/2310e846093415cddda96987558409298d4df056/google_classroom/main.py#L115

zkagin commented 4 years ago

Just to clarify, do you want to pull in inactive courses to the database as well then?