search

kipr / harrogate

The IDE for the Wombat
GNU General Public License v3.0
5 stars 10 forks source link

[RFR] Export as .zip (javascript version) #39

Closed jsoutherland closed 8 years ago

jsoutherland commented 8 years ago

I have moved over the work by @swatkins in #31 since we have a new javascript version of the codebase.

I can confirm that it allows users to download a .zip if the project only contains a single file.

If there are multiple files, there is an error:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: already processing an entry
    at ArchiveOutputStream.entry (/home/josh/got/tmp/harrogate/node_modules/zip-stream/node_modules/compress-commons/lib/archivers/archive-output-stream.js:75:14)
    at ZipStream.entry (/home/josh/got/tmp/harrogate/node_modules/zip-stream/lib/zip-stream.js:105:49)
    at /home/josh/got/tmp/harrogate/apps/programs/project.js:87:20
    at fs.js:268:14
    at Object.oncomplete (fs.js:107:15)

stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
Error: read ECONNRESET
    at errnoException (net.js:901:11)
    at Pipe.onread (net.js:556:19)

This occurs when handling the second file in the project. I'll look into it.

jsoutherland commented 8 years ago

This works now. zip-steam used an opposite argument order from tar-stream.