kipraske / web-brogue

Play brogue in a web browser
GNU General Public License v2.0
20 stars 17 forks source link

Feature/latest fixes #51

Closed flend closed 8 years ago

flend commented 8 years ago

This PR has a number of important fixes:

Supporting the latest ngram library Fixing a number of crashes due to mouse over

Also note the documentation on datagram settings in the server - you can make the mouseover more reliable with a sysctrl call

kipraske commented 8 years ago

I am attempting to update the brogue.lumenstone.org server with this code but I have ran into some serious bugs. In particular, it seems that I cannot view recordings at all. Is there a dependency that I may be missing?

flend commented 8 years ago

Kip,

a) whoops, I think I just pushed my latest changes to your master branch :) Ignore the PR.

b) You need to run npm install to get the ngram 1.0.0 release. That is probably causing your problem.

c) You should recompile brogue since I've made some fixes to improve performance when watching recordings

Sorry for the hassle :)

Tom

On 23 June 2016 at 21:25, Kip Raske notifications@github.com wrote:

I am attempting to update the brogue.lumenstone.org server with this code but I have ran into some serious bugs. In particular, it seems that I cannot view recordings at all. Is there a dependency that I may be missing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kipraske/web-brogue/pull/51#issuecomment-228172619, or mute the thread https://github.com/notifications/unsubscribe/ADTFLID2qfdT0VomtEoMtGCx1H-v3BFfks5qOuuggaJpZM4IuMNG .