kipusoep / UrlTracker

The Url Tracker for Umbraco
MIT License
54 stars 61 forks source link

Excessive INFO logging from nuget v3.13.0 #165

Closed PhilDye closed 7 years ago

PhilDye commented 7 years ago

The built version released in v3.13.0 (from nuget) appears to have an extra LogHelper.Info in LoggingHelper.LogInformation - this method normally logs at level DEBUG only.

Verified by building from current source, which no longer logs at INFO, and inspection of nuget-released DLL using DotPeek.

PhilDye commented 7 years ago

Decompiled nuget v3.13.0 method; note extra LogHelper.Info call;

public static void LogInformation(string message)
    {
      LogHelper.Info(typeof (LoggingHelper), message, new Func<object>[0]);
      if (!UrlTrackerSettings.EnableLogging)
        return;
      LogManager.GetLogger(typeof (LoggingHelper)).Debug((object) message);
      LogHelper.Debug(typeof (LoggingHelper), (Func<string>) (() => message));
      UrlTrackerLogging.Log(message);
    }
daniel-chenery commented 7 years ago

@PhilDye Doh! That would be some left over test code for always force logging. Will remove and update shortly 🙄

Thanks!

PhilDye commented 7 years ago

@daniel-chenery I'm guessing the AppVeyor build isn't automatically releasing to nuget?

daniel-chenery commented 7 years ago

@PhilDye Nope :(

daniel-chenery commented 7 years ago

@PhilDye The correct build should be on NuGet now.

I'll look into the AppVeyor stuff - thanks!