Closed kipyin closed 5 years ago
The issue with shipping pokedex
with pokemaster
:
So, nah. I think I'll try to fix this issue on the PyPI side.
Note: pip install git+https://github.com/veekun/pokedex
works. How should I put this into pyproject.toml
?
So this is actually an issue with poetry
, who strips the git dependencies when building the package. I can:
poetry
. But I have no idea how to fix the wheel part.requirements.txt
for now.Installing pokedex
separately can also be a solution.
We can make it easier by incorporating pip install git+<pokedex.git>
in tasks.py
, like:
def install(c):
c.run("pip install git+https://github.com/veekun/pokedex")
c.run("poetry install -v")
If so, construct
dependency can be removed from the main requirements, along with many other benefits.
With this maybe we can finally do pip install pokemaster
:
$ pip install git+https://github.com/veekun/pokedex
...
$ pip install pokemaster
Then all we need to worry about is installing pokedex
to the right virtualenv.
pip install pokemaster
does not work:I've searched all existing issues on
poetry
and cannot find a solution to this (or even a relevant issue). I thinkpokedex
should be shipped withpokemaster
.