search

kipyin / pokemaster

Checkout kipyin/pokemaster2 !
https://github.com/kipyin/pokemaster2
2 stars 2 forks source link

Should `pokemaster.database` be private? #9

Open kipyin opened 5 years ago

kipyin commented 5 years ago

I use a centralized pokemaster.database to manage all the query functions. But I think all functions in pokemaster.database should not be used by the end users directly. Hence, in the most recent commit 586d8ca357bf8397689aca18b32fb3da64a031ed, I've made it a private module, but I'm not entirely sure about this change.

Making pokemaster.database a private module makes perfect sense. The only thing the end users should use is really just pokemaster.Pokemon. The end users should not worry about all the SQLAlchemy tables under the hood. Only the vanilla Python types should be used as the arguments for the public APIs.

If there is no downside of having the module to be private, I'll include this change in release v0.1.

kipyin commented 5 years ago

Also, if pokemaster.database is private, should it be tested (I don't think so)?