search

kir-dev / schbody

https://body.sch.bme.hu
1 stars 0 forks source link

period with the id of 0 is fetched on periods page #54

Closed Tschonti closed 2 months ago

Tschonti commented 2 months ago

If you open the periods page, application-periods/0 is also called alongside application-periods. No idea why, but it could be fixed by checking the ID the swr hook and only enabling it if it's a valid id.

linear[bot] commented 2 months ago

KIR-54 period with the id of 0 is fetched on periods page

FearsomeRover commented 2 months ago

Good spot, it should be fixed now. It had to do with preloading the dialogs for period editing, and having a default 0 there as fallback.