kir4h / rvault

Small tool to perform some recursive operations on Hashicorp's Vault KV
MIT License
46 stars 11 forks source link

ci: build images for arm64 architecture e.g. for new Macs #14

Closed cmur2 closed 1 year ago

cmur2 commented 1 year ago

A colleague of mine wants to use the tool on his new M1 Mac book but there was no binary readily available. I had a look how other projects with goreleaser do this.

It seems unconditionally building an arm64 flavor for all OSes (Linux can run on that, too) would be the easiest way, but I didn't test it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #14 (33b4ab0) into master (38d5aef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files           6        6           
  Lines         260      260           
=======================================
  Hits          233      233           
  Misses         13       13           
  Partials       14       14           
Flag Coverage Δ
unittests 89.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kir4h commented 1 year ago

Thanks for your contribution @cmur2 . I don´t have an ARM at hand for testing, but according to the documentation this should be fine. https://goreleaser.com/customization/build/ even shows an example where windows and arm64 are on the matrix.

kir4h commented 1 year ago

@cmur2 v1.0.1 released, includes arm64 version

cmur2 commented 1 year ago

Thanks a lot, maybe @langleu can give it a try? I also created a plugin for the asdf-vm.com version manager which should fetch the right binary 🤞🏼

Langleu commented 1 year ago

@kir4h, thank you! It's working perfectly on ARM macs!

kir4h commented 1 year ago

Thanks a lot, maybe @Langleu can give it a try? I also created a plugin for the asdf-vm.com version manager which should fetch the right binary 🤞🏼

Thanks! I will include a note in the documentation about the plugin

@kir4h, thank you! It's working perfectly on ARM macs!

Glad to hear!