search

kir4h / rvault

Small tool to perform some recursive operations on Hashicorp's Vault KV
MIT License
46 stars 11 forks source link

Use vault testing utilities instead of mocking #2

Closed kir4h closed 4 years ago

kir4h commented 4 years ago

This PR closes #1 by changing the way of testing from mocking Vault to using actual Vault libraries for a simpler and more reliable testing

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will increase coverage by 6.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   84.26%   90.52%   +6.26%     
==========================================
  Files           6        6              
  Lines         286      285       -1     
==========================================
+ Hits          241      258      +17     
+ Misses         27       13      -14     
+ Partials       18       14       -4
Flag Coverage Δ
#unittests 90.52% <100.00%> (+6.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/pkg/api/client.go 100.00% <100.00%> (+22.22%) :arrow_up:
internal/pkg/kv/kv.go 81.25% <100.00%> (+14.58%) :arrow_up:
internal/pkg/kv/list.go 90.76% <100.00%> (-9.24%) :arrow_down:
internal/pkg/kv/read.go 96.77% <100.00%> (+9.05%) :arrow_up:
internal/pkg/output/output.go 84.37% <0.00%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 200ad47...d7a01bd. Read the comment docs.